Re: [PATCH] usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 11, 2021 at 03:04:09PM +0200, Heikki Krogerus wrote:
> Hi,
> 
> On Thu, Mar 11, 2021 at 01:47:10PM +0100, Elias Rudberg wrote:
> > Remove the unused "u32 vdo[3]" part in the tps6598x_rx_identity_reg
> > struct. This helps avoid "failed to register partner" errors which
> > happen when tps6598x_read_partner_identity() fails because the
> > amount of data read is 12 bytes smaller than the struct size.
> > Note that vdo[3] is already in usb_pd_identity and hence
> > shouldn't be added to tps6598x_rx_identity_reg as well.
> > 
> > Fixes: f6c56ca91b92 ("usb: typec: Add the Product Type VDOs to struct usb_pd_identity")
> > 
> > Signed-off-by: Elias Rudberg <mail@xxxxxxxxxxxxxxx>
> 
> This needs to go to the stable kernels as well. Please resend with the
> appropriate "Cc: stable@xxxxxxxxxxxxxxx" tag. Please also include my
> reviewed-by tag:
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

I can add the cc: stable when committting this, thanks.

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux