Re: [PATCH 1/3] thunderbolt: Add details to router uevent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mario,

On Wed, Mar 10, 2021 at 05:28:19PM +0000, Limonciello, Mario wrote:
> 
> 
> > -----Original Message-----
> > From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Sent: Tuesday, March 9, 2021 7:48
> > To: linux-usb@xxxxxxxxxxxxxxx
> > Cc: Michael Jamet; Yehezkel Bernat; Andreas Noever; Lukas Wunner; Limonciello,
> > Mario; Christian Kellner; Benson Leung; Prashant Malani; Diego Rivas; Greg
> > Kroah-Hartman; Mika Westerberg
> > Subject: [PATCH 1/3] thunderbolt: Add details to router uevent
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > Expose two environment variables for routers as part of the initial
> > uevent:
> > 
> >   USB4_VERSION=1.0
> >   USB4_TYPE=host|device|hub
> 
> Presumably this will then show up in the uevent like this for a host controller:
> DEVTYPE=thunderbolt_device
> USB4_VERSION=1.0
> USB4_TYPE=host
> 
> Since it's specifically for USB4, how about if you instead have new devtypes?
> TBT3:
> DEVTYPE=thunderbolt_device
> 
> USB4:
> DEVTYPE=usb4_host|usb4_device|usb4_hub
> 
> That would at least make it clearer to userspace to make a delineation if it's
> legacy device or not.   I don't know if that's actually valuable information however.

Unfortunately we can't do that. DEVTYPE is generated by the driver core
based on the struct device_type we register for routers (switches). Also
bolt, and I think fwupd too, already use DEVTYPE to distinguish routers
from other devices (like XDomains etc).



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux