On Tue, Mar 9, 2021 at 11:22 AM Gil Fine <gil.fine@xxxxxxxxx> wrote: > > Currently, when first failure occurs while reading of the block, > we stop reading the block and jump to the next capability. > This doesn't cover the case of block with "holes" of inaccessible > dwords, followed by accessible dwords. > This patch address this problem. > In case of failure while reading the complete block in one transaction, > (because of one or more dwords is inaccessible), we read the remaining > dwords of the block dword-by-dword, one dword per transaction, > till the end of the block. Just wondering: is there any chance this will slow down the device adding flow if there are many inaccessible dwords, or we expect the read to return immediately for such dwords? If for some devices it may be a slow process, does it make sense to have a way to disable this feature for specific devices or by a module parameter? Maybe we don't worry about it as it's only for debugfs? Thanks, Yehezkel