On Wed, Mar 03, 2021 at 11:24:01AM +0100, Krzysztof Kozlowski wrote: > On 03/03/2021 03:26, taehyun cho wrote: > >'ARCH_EXYNOS' is not suitable for DWC3_EXYNOS config. > >'USB_DWC3_EXYNOS' is glue layer which can be used with > >Synopsys DWC3 controller on Exynos SoCs. USB_DWC3_EXYNOS' > >can be used from Exynos5 to Exynos9. > > > >Signed-off-by: taehyun cho <taehyun.cho@xxxxxxxxxxx> > > NACK because you ignored comments from March. Please respond to them instead > of resending the same patch. > > Anyway, when resending you need to version your patches and explain the > differences. Please also Cc reviewers and other maintainers. I pointed out > this before: > scripts/get_maintainer.pl -f drivers/usb/dwc3/dwc3-exynos.c > > The driver - in current form - should not be available for other > architectures. It would clutter other platforms and kernel config selection. > If you want to change this, you need to provide rationale (usually by adding > support to new non-Exynos platform). > > Best regards, > Krzysztof > Sorry for not answering the comments previously. I was confused with the policy. I couldn't use 'USB_DWC3_EXYNOS' when 'ARCH_EXYNOS' was not defined. That's why I changed 'ARCH_EXYNOS' to 'USB_DWC3'. I modified changelog text from previous commit. I saw some more discussion was done about 'ARCH_XX'. I will wait for the decision. Thanks. Best Regards, Taehyun Cho
