On Wed, Mar 03, 2021 at 03:15:53PM +0800, tiantao (H) wrote: > > 在 2021/3/3 15:02, Greg KH 写道: > > On Wed, Mar 03, 2021 at 09:09:12AM +0800, Tian Tao wrote: > > > Remove including <linux/version.h> that don't need it. > > > > > > Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx> > > > --- > > > drivers/usb/core/hcd.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > > > index 3f03813..53bc93d 100644 > > > --- a/drivers/usb/core/hcd.c > > > +++ b/drivers/usb/core/hcd.c > > > @@ -11,7 +11,6 @@ > > > #include <linux/bcd.h> > > > #include <linux/module.h> > > > -#include <linux/version.h> > > > #include <linux/kernel.h> > > > #include <linux/sched/task_stack.h> > > > #include <linux/slab.h> > > You obviously did not even test-build this patch, which is very odd when > > submitting something to the community. Why did you not do this? > > > > This file _DOES_ need this .h file, whatever tool you are using to > > detect this is completely broken. Please fix it and be more careful > > before sending new patches. > this is reported by command “make versioncheck” Then the tool is broken. Why did you not test-build your change before sending it? Did you read the checklist of "what to do before sending a patch" that we have in our documentation? If not, please do so. thanks, greg k-h
