On Tue, Feb 16, 2021 at 03:46:45PM +0100, Greg Kroah-Hartman wrote:
> The single debugfs file for this driver really is a log file, so make a
> subdir and call it "log" to make it obvious this is what it is for.
> This makes cleanup simpler as we just remove the whole directory, no
> need to handle individual files anymore.
>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 22a85b396f69..d4dd40c95a56 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -636,8 +636,9 @@ static void tcpm_debugfs_init(struct tcpm_port *port)
>
> mutex_init(&port->logbuffer_lock);
> snprintf(name, NAME_MAX, "tcpm-%s", dev_name(port->dev));
> - port->dentry = debugfs_create_file(name, S_IFREG | 0444, usb_debug_root,
> - port, &tcpm_debug_fops);
> + port->dentry = debugfs_create_dir(name, usb_debug_root);
> + debugfs_create_file("log", S_IFREG | 0444, port->dentry, port,
> + &tcpm_debug_fops);
> }
>
> static void tcpm_debugfs_exit(struct tcpm_port *port)
> --
> 2.30.1
--
heikki
