Re: [PATCH v2] usb: xhci: do not perform Soft Retry for some xHCI hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.2.2021 10.12, stf_xl@xxxxx wrote:
> From: Stanislaw Gruszka <stf_xl@xxxxx>
> 
> Since f8f80be501aa ("xhci: Use soft retry to recover faster from
> transaction errors") on some systems rt2800usb and mt7601u devices
> are unable to operate. Possible reason is that some xHCI hardware
> can not perform Soft Retry for those devices correctly.
> 
> To avoid the problem add xhci->quirks flag that restore pre f8f80be501aa
> xhci behaviour for affected xHCI controllers. Currently those are
> AMD_PROMONTORYA_4 and AMD_PROMONTORYA_2, since it was confirmed
> by the users: on those xHCI hosts issue happen and is gone after
> disabling Soft Retry.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202541
> Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors")
> Reported-and-tested-by: Bernhard <bernhard.gebetsberger@xxxxxx>
> Bisected-by: Bernhard <bernhard.gebetsberger@xxxxxx>
> Signed-off-by: Stanislaw Gruszka <stf_xl@xxxxx>
> ---
> v1 -> v2:
> compared to previous patch:
> https://lore.kernel.org/linux-usb/20210122104342.12451-1-stf_xl@xxxxx/t/#u
> now we use xhci->quirks to disable Soft Retry (I also changed topic
> to reflect the change).
> 
>  drivers/usb/host/xhci-pci.c  | 5 +++++
>  drivers/usb/host/xhci-ring.c | 3 ++-
>  drivers/usb/host/xhci.h      | 1 +
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 


Thanks.

Checkpatch complains about some minor things, I'll fix those while applying.
Will send forward after 5.12-rc1 is out, and add stable tag.

-Mathias



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux