Greg Kroah-Hartman wrote: > On Fri, Feb 05, 2021 at 09:39:37AM +0000, Thinh Nguyen wrote: >> Greg Kroah-Hartman wrote: >>> On Wed, Feb 03, 2021 at 08:14:37PM -0800, Thinh Nguyen wrote: >>>> The check for bounded gadget driver in dwc3_gadget_start() was to >>>> prevent going through the initialization again without any cleanup. With >>>> a recent update, the UDC framework guarantees this won't happen while >>>> the UDC is started. Also, this check doesn't prevent requesting threaded >>>> irq to the same dev_id, which will mess up the irq freeing logic. Let's >>>> remove it. >>> What "recent update" caused this? Is this a fix for something that >>> needs to be backported? If so, can you provide a "Fixes:" tag on here? >>> Or is this just a general cleanup that is good to do now. >>> >>> thanks, >>> >>> greg k-h >> It's general cleanup. The "recent update" is not in mainline yet but on >> your "usb-next" branch so I'm not sure how to properly reference it. >> >> But here's the commit on your branch I was referring to: 49d08cfc7830 >> ("usb: udc: core: Introduce started state") > Please refer to this commit just like this, as the id is not going to > change. Can you redo this patch with that information in it? > > thanks, > > greg k-h Will do. Thanks, Thinh