[usb:usb-testing 158/166] drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted __le16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
head:   2a16e18c3400f7ab1deb826a98cf52153d03653e
commit: 3b3dd1f0dbfe92781c60f36ea5c22b26360f9909 [158/166] platform/chrome: cros_ec_typec: Report SOP' PD revision from status
config: i386-randconfig-s001-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=3b3dd1f0dbfe92781c60f36ea5c22b26360f9909
        git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
        git fetch --no-tags usb usb-testing
        git checkout 3b3dd1f0dbfe92781c60f36ea5c22b26360f9909
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted __le16

vim +900 drivers/platform/chrome/cros_ec_typec.c

   870	
   871	static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num)
   872	{
   873		struct ec_response_typec_status resp;
   874		struct ec_params_typec_status req = {
   875			.port = port_num,
   876		};
   877		int ret;
   878	
   879		ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_STATUS, &req, sizeof(req),
   880					    &resp, sizeof(resp));
   881		if (ret < 0) {
   882			dev_warn(typec->dev, "EC_CMD_TYPEC_STATUS failed for port: %d\n", port_num);
   883			return;
   884		}
   885	
   886		/* Handle any events appropriately. */
   887		if (resp.events & PD_STATUS_EVENT_SOP_DISC_DONE && !typec->ports[port_num]->sop_disc_done) {
   888			ret = cros_typec_handle_sop_disc(typec, port_num);
   889			if (ret < 0)
   890				dev_err(typec->dev, "Couldn't parse SOP Disc data, port: %d\n", port_num);
   891			else
   892				typec->ports[port_num]->sop_disc_done = true;
   893		}
   894	
   895		if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE &&
   896		    !typec->ports[port_num]->sop_prime_disc_done) {
   897			u16 sop_prime_revision;
   898	
   899			/* Convert BCD to the format preferred by the TypeC framework */
 > 900			sop_prime_revision = (le16_to_cpu(resp.sop_prime_revision) & 0xff00) >> 4;
   901			ret = cros_typec_handle_sop_prime_disc(typec, port_num, sop_prime_revision);
   902			if (ret < 0)
   903				dev_err(typec->dev, "Couldn't parse SOP' Disc data, port: %d\n", port_num);
   904			else
   905				typec->ports[port_num]->sop_prime_disc_done = true;
   906		}
   907	}
   908	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux