Hi Gil, On Mon, Feb 01, 2021 at 11:46:37PM +0200, Gil Fine wrote: > There are cases when reading block of dwords in single transaction fail, > for several reasons, mostly if HW publish to implement all of the dwords, > while actually it doesn't or if some dwords not accessible for read > for security reasons. We handle these cases by trying to read the block, > dword-by-dword, one dword per transaction, till we get a failure. > We drop the not-used functions: > tb_switch_is_tiger_lake() and tb_switch_is_ice_lake() Can you do this part (dropping the unused functions) in a separate patch? Otherwise looks good to me.