On Sun, Jan 24, 2021 at 10:38:53PM +0800, angkery wrote:
> From: Junlin Yang <yangjunlin@xxxxxxxxxx>
>
> PTR_ERR(chip->tcpci) has been used as a return value,
> it is not necessary to assign it to ret, so remove it.
>
> Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> v3:remove the newline modification.
>
> drivers/usb/typec/tcpm/tcpci_maxim.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 3192663..7f54f51a 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -461,7 +461,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id
> chip->tcpci = tcpci_register_port(chip->dev, &chip->data);
> if (IS_ERR(chip->tcpci)) {
> dev_err(&client->dev, "TCPCI port registration failed");
> - ret = PTR_ERR(chip->tcpci);
> return PTR_ERR(chip->tcpci);
> }
> chip->port = tcpci_get_tcpm_port(chip->tcpci);
> --
> 1.9.1
thanks,
--
heikki
