On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote: > > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper <alcooperx@xxxxxxxxx> wrote: ... > > > Not sure this makes sense, given that the DMA hardware that was added to > > > this UART block is only used by the UART block and no other pieces of HW > > > in the system, nor will they ever be. Not sure it makes sense to pay the > > > cost of an extra indirection and subsystem unless there are at least two > > > consumers of that DMA hardware to warrant modeling it after a dmaengine > > > driver. I also remember that Al researched before whether 8250_dma.c > > > could work, and came to the conclusion that it would not, but I will let > > > him comment on the specifics. > > > > I see. In any case I still believe that the driver can be shrinked by > > a notable amount of lines. > > Patches always gladly accepted :) Or a good review... :-) -- With Best Regards, Andy Shevchenko