On Mon, Jan 18, 2021 at 01:54:16PM +0100, Patrik Jakobsson wrote: > On Mon, Jan 18, 2021 at 1:22 PM Felipe Balbi <balbi@xxxxxxxxxx> wrote: > > > > > > Hi, > > > > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > >> Al Cooper <alcooperx@xxxxxxxxx> writes: > > >> > The BDC PCI driver was only used for design verification with > > >> > an PCI/FPGA board. The board no longer exists and is not in use > > >> > anywhere. All instances of this core now exist as a memory mapped > > >> > device on the platform bus. > > >> > > > >> > NOTE: This only removes the PCI driver and does not remove the > > >> > platform driver. > > >> > > > >> > Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx> > > >> > > >> It sounds like it could be used for pre-silicon verification of newer > > >> Core Releases, much like Synopsys still uses the HAPS (with mainline > > >> linux, mind you) for silicon validation. > > >> > > >> Why would we delete this small shim if it *could* still be useful? > > > > > > It ends up conflicting with the PCI id of a device that is actually in > > > the wild (a camera on Apple laptops). So it's good to drop this driver > > > so the wrong driver doesn't get constantly bound to the wrong device. > > > > I see. Oh well... > > It would also help if this got disabled in stable so existing kernels > stop loading bdc. > > Can this patch go directly into stable or should I send a patch that > adds "depends on BROKEN"? A patch for that, that I can take now for 5.11-final and backport to stable kernels would be fine. thanks, greg k-h
