On Thu, Jan 14, 2021 at 1:19 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > - bool zlp; > > - bool no_skb_reserve; > > + bool zlp:1; > > + bool no_skb_reserve:1; > > + bool ifname_set:1; > > Not to be a pain, but "bool var:1"? What's wrong with just a bool > itself? gcc is known to have issues with setting/clearing bit fields > like this, and there is no size issues here with this device, adding one > more byte is just fine. > > So just add: > bool ifname_set; Ack. I guess turning it into a bitfield was premature optimization. Sent out v3 where this is its own boolean.
