On Wed, Jul 29, 2009 at 06:36:14PM +0200, Valentin Longchamp wrote: > Sergei Shtylyov wrote: >> Looks like you're kind of duplicating what's already in >> <linux/usb/otg.h>. More so because your transceiver is also OTG one, so >> it seems it should be using 'struct otg_transceiver' already defined >> there. > > I have looked at the otg transceiver current implementation. I have the > feeling (correct me if I'm wrong) that they do not achieve the same > purpose. It is more dedicated to operations like changing the state of > the transceiver (set to host/gadget mode). > > In Daniel's implemementation, the functions are more related to the > power and platform specific parts (initialisation, shutdown, set_vbus). > > The otg_transceiver struct could be used, but shouldn't it be extended ? > If not how would I for instance implement init and set_vbus ? That was my first impression as well when I had a look at what's already there, yes. I'd like to do another spin these days, so I'm looking forward to clarification on this. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
