Hi Greg, On 1/4/2021 1:55 PM, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2021 at 01:38:43PM +0530, Tejas Joglekar wrote: >> This commit adds the platform device data to setup >> the XHCI_SG_TRB_CACHE_SIZE_QUIRK quirk. DWC3 hosts >> which are PCI devices does not use OF to create platform device >> but create xhci-plat platform device at runtime. So >> this patch allows parent device to supply the quirk >> through platform data. >> >> Signed-off-by: Tejas Joglekar <joglekar@xxxxxxxxxxxx> >> --- >> drivers/usb/dwc3/host.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > What changed from previous versions? Resent the patch as it was missed for review by Felipe and I saw your mail to resend the patch if not reviewed. Other two patches from series are picked up by Mathias, this one is remaining for review. > >> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c >> index e195176580de..0434bc8cec12 100644 >> --- a/drivers/usb/dwc3/host.c >> +++ b/drivers/usb/dwc3/host.c >> @@ -11,6 +11,11 @@ >> #include <linux/platform_device.h> >> >> #include "core.h" >> +#include "../host/xhci-plat.h" > That feels really wrong. Are you sure about that? To use the struct xhci_plat_priv this was included, can you suggest alternative? > > thanks, > > greg k-h Thanks & Regards, Tejas Joglekar
