On Tue, Dec 15, 2020 at 04:56:21PM +0100, Dave Penkler wrote: > The previous patches in this series have changed the behaviour of the > driver and added new calls. > > Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx> > Reviewed-by: Guido Kiener <guido.kiener@xxxxxxxxxxxxxxxxx> > Tested-by: Jian-Wei Wu <jian-wei_wu@xxxxxxxxxxxx> > --- > drivers/usb/class/usbtmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c > index d2fcc698c745..74d5a9c5238a 100644 > --- a/drivers/usb/class/usbtmc.c > +++ b/drivers/usb/class/usbtmc.c > @@ -25,7 +25,7 @@ > /* Increment API VERSION when changing tmc.h with new flags or ioctls > * or when changing a significant behavior of the driver. > */ > -#define USBTMC_API_VERSION (2) > +#define USBTMC_API_VERSION (3) Why is this needed? You should be able to detect new calls by just doing the ioctl and checking right? I'll take this for now, but versioning apis is not a good thing to do in general. thanks, greg k-h
