On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > preferred for a single entry while greater than 1 should have an 'items' > > list. > > > > A meta-schema check for this is pending once these existing cases are > > fixed. > > > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > > Cc: Mark Brown <broonie@xxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: dmaengine@xxxxxxxxxxxxxxx > > Cc: alsa-devel@xxxxxxxxxxxxxxxx > > Cc: linux-usb@xxxxxxxxxxxxxxx > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > With one comment below, > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > --- > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > index 737c1f47b7de..54c361d4a7af 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > @@ -74,11 +74,8 @@ properties: > > > > phys: > > maxItems: 1 > > - items: > > - - description: phandle + phy specifier pair. > > The description may help some people, so keeping the > description and deleting maxItems would maybe be better. Do we really want to describe 'phys' hundreds of times? No. The question I ask on the descriptions is could it be generated instead. Rob
