On Mon, Dec 21, 2020 at 08:25:47AM -0800, trix@xxxxxxxxxx wrote: > From: Tom Rix <trix@xxxxxxxxxx> > > Attributing the function allows the compiler to more thoroughly > check the use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > --- > drivers/usb/musb/musb_debug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/musb/musb_debug.h b/drivers/usb/musb/musb_debug.h > index e5b3506c7b3f..dfc0d02695fa 100644 > --- a/drivers/usb/musb/musb_debug.h > +++ b/drivers/usb/musb/musb_debug.h > @@ -17,6 +17,7 @@ > #define INFO(fmt, args...) yprintk(KERN_INFO, fmt, ## args) > #define ERR(fmt, args...) yprintk(KERN_ERR, fmt, ## args) > > +__printf(2, 3) > void musb_dbg(struct musb *musb, const char *fmt, ...); While I understand the need for this, did this find any problems? If not, then it's not worth adding, the driver-specific debugging macros should be removed entirely and just use dev_dbg() and friends instead. thanks, greg k-h
