On Mon, Dec 14, 2020 at 07:32:11PM +0800, Zou Wei wrote:
> Fix variable set but not used compilation warnings:
>
> drivers/usb/host/xhci.c:1338:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
> unsigned int len;
> ^~~
>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
> drivers/usb/host/xhci.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 91ab81c..24e5a0f 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1335,7 +1335,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
>
> static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> {
> - unsigned int len;
> unsigned int buf_len;
> enum dma_data_direction dir;
>
> @@ -1351,10 +1350,10 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> dir);
>
> if (usb_urb_dir_in(urb))
> - len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> - urb->transfer_buffer,
> - buf_len,
> - 0);
> + sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> + urb->transfer_buffer,
> + buf_len,
> + 0);
Why not test that this worked properly?
thanks,
greg k-h
