Hi Martin
On 05/12/2020 22:42, Martin Blumenstingl wrote:
Hello Amjad,
On Tue, Dec 1, 2020 at 8:01 PM Amjad Ouled-Ameur
<aouledameur@xxxxxxxxxxxx> wrote:
reset_control_(de)assert() calls are called on a shared reset line when
reset_control_reset has been used. This is not allowed by the reset
framework.
Use reset_control_rearm() call in suspend() and remove() as a way to state
that the resource is no longer used, hence the shared reset line
may be triggered again by other devices. Use reset_control_rearm() also in
case probe fails after reset() has been called.
reset_control_rearm() keeps use of triggered_count sane in the reset
framework, use of reset_control_reset() on shared reset line should be
balanced with reset_control_rearm().
I think this should be updated after [0] is applied
The goto from that patch needs to use err_rearm from this patch.
Best regards,
Martin
[0] https://patchwork.kernel.org/project/linux-usb/patch/20201111095256.10477-1-zhengzengkai@xxxxxxxxxx/
Thank you Martin for reviewing this patchset.
I have reviewed the patch you mentioned, and I think as well that
we should use 'err_rearm' instead of 'err_disable_clks' to
cleanup things properly in case setup_regmaps fails.
Best,
Amjad
