Re: [PATCH] USB: serial: ftdi_sio: Helpful error on GPIO attempt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 08, 2020 at 09:39:25AM +0100, Linus Walleij wrote:
> On Wed, Dec 2, 2020 at 7:13 PM Marc Zyngier <maz@xxxxxxxxxx> wrote:
> 
> > And to clarify what I mean, here's a patchlet that does the trick.
> >
> > maz@tiger-roach:~$ sudo gpioinfo gpiochip3
> > gpiochip3 - 4 lines:
> >         line   0:      unnamed       unused  output  active-high
> >         line   1:      "AltFunc"     kernel  input   active-high [used]
> >         line   2:      "AltFunc"     kernel  input   active-high [used]
> >         line   3:      "AltFunc"     kernel  input   active-high [used]
> >
> > It at least make clear that you can't grab the GPIO. Of course, you
> > don't get the message that you just added...
> 
> I think this looks good.
> 
> > +#include "../../gpio/gpiolib.h"
> 
> I suppose I can live with this because it's for a noble cause.

Not needed, Marc fixed that bit up in his series.

> > Thoughts?
> 
> Could you combine it with a patch similar to min giving some probe() time
> information that some GPIO lines are altfunc and where to get the tool
> and send a proper patch?

He already did that, but I'm sceptical to spamming the logs with this
(we don't explain how people should setup up pinmuxing in their device
trees in the logs either). Please take a look at the discussion
following Marc's series.

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux