On Tue, Oct 20, 2020 at 11:37:50AM +0300, Andy Shevchenko wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
Felipe, any comments?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-keystone.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
> index 9a99253d5ba3..057056c0975e 100644
> --- a/drivers/usb/dwc3/dwc3-keystone.c
> +++ b/drivers/usb/dwc3/dwc3-keystone.c
> @@ -99,13 +99,8 @@ static int kdwc3_probe(struct platform_device *pdev)
>
> /* PSC dependency on AM65 needs SERDES0 to be powered before USB0 */
> kdwc->usb3_phy = devm_phy_optional_get(dev, "usb3-phy");
> - if (IS_ERR(kdwc->usb3_phy)) {
> - error = PTR_ERR(kdwc->usb3_phy);
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "couldn't get usb3 phy: %d\n", error);
> -
> - return error;
> - }
> + if (IS_ERR(kdwc->usb3_phy))
> + return dev_err_probe(dev, PTR_ERR(kdwc->usb3_phy), "couldn't get usb3 phy\n");
>
> phy_pm_runtime_get_sync(kdwc->usb3_phy);
>
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
