Re: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 23, 2020 at 10:58 AM Jim Quinlan <james.quinlan@xxxxxxxxxxxx> wrote:
>
> On Fri, Nov 20, 2020 at 2:45 PM Al Cooper <alcooperx@xxxxxxxxx> wrote:
> >
> > From: Jim Quinlan <jquinlan@xxxxxxxxxxxx>
> >
> > This commit has of_platform_serial_probe() check specifically for the
> > "brcm,bcm7271-uart" and whether its companion driver is enabled. If it
> > is the case, and the clock provider is not ready, we want to make sure
> > that when the 8250_bcm7271.c driver returns EPROBE_DEFER, we are not
> > getting the UART registered via 8250_of.c.
> >
> > Signed-off-by: Jim Quinlan <jquinlan@xxxxxxxxxxxx>
> > ---
> >  drivers/tty/serial/8250/8250_of.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
> > index 65e9045dafe6..aa458f3c6644 100644
> > --- a/drivers/tty/serial/8250/8250_of.c
> > +++ b/drivers/tty/serial/8250/8250_of.c
> > @@ -192,6 +192,10 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> >         u32 tx_threshold;
> >         int ret;
> >
> > +       if (IS_ENABLED(CONFIG_SERIAL_8250_BCM7271) &&
> > +           of_device_is_compatible(ofdev->dev.of_node, "brcm,bcm7271-uart"))
> > +               return -ENODEV;
> > +
> NOTE: this commit is a "strawman" commit, and I will not be surprised
> if it gets quickly NAKed. We have a new idea on how to solve this
> issue, and if that not is not viable, will ask for a dialog on this
> problem either in this thread or through a separate RFC.


This commit is no longer needed  as part of this patchset; we have
addressed the problem elsewhere.  Sorry about the noise.
>
>
> Regards,
> Jim Quinlan
> Broadcom STB
>
>
>
> >         port_type = (unsigned long)of_device_get_match_data(&ofdev->dev);
> >         if (port_type == PORT_UNKNOWN)
> >                 return -EINVAL;
> > --
> > 2.17.1
> >

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux