Re: [PATCH 0/2] Remove one more platform_device_add_properties() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus
> <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > I originally introduced these as part of my series where I was
> > proposing PM ops for software nodes [1], but since that still needs
> > work, I'm sending these two separately.
> >
> > So basically I'm only modifying dwc3-pci.c so it registers a software
> > node directly at this point. That will remove one more user of
> > platform_device_add_properties().
> >
> > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@xxxxxxxxxxxxxxx/
> >
> > thanks,
> >
> > Heikki Krogerus (2):
> >   software node: Introduce device_add_software_node()
> >   usb: dwc3: pci: Register a software node for the dwc3 platform device
> >
> >  drivers/base/swnode.c       | 69 ++++++++++++++++++++++++++++++++-----
> >  drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++-------------
> >  include/linux/property.h    |  3 ++
> >  3 files changed, 100 insertions(+), 33 deletions(-)
> >
> > --
> 
> These look good to me.
> 
> If you want me to take them, though, I need an ACK from the dwc3 side.

Btw, I have tested this on one of the platform with DWC3 and found no
regression, so feel free to add

Tested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux