Re: [PATCH] option: added support for Thales Cinterion MV31 option port.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ johan

On 11/23/2020 15:20, Lars Melin wrote:
On 11/19/2020 18:59, Giacinto Cifelli wrote:
There is a single option port in this modem, and it is used as debug port

Signed-off-by: Giacinto Cifelli <gciofono@xxxxxxxxx>
---
  drivers/usb/serial/option.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 54ca85cc920d..3ad86a6e8487 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -424,6 +424,7 @@ static void option_instat_callback(struct urb *urb);
  #define CINTERION_PRODUCT_AHXX_2RMNET        0x0084
  #define CINTERION_PRODUCT_AHXX_AUDIO        0x0085
  #define CINTERION_PRODUCT_CLS8            0x00b0
+#define CINTERION_PRODUCT_EXS82            0x006c
  /* Olivetti products */
  #define OLIVETTI_VENDOR_ID            0x0b3c
@@ -1908,6 +1909,8 @@ static const struct usb_device_id option_ids[] = {
      { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC25_MDMNET) },
      { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC28_MDM) }, /* HC28 enumerates with Siemens or Cinterion VID depending on FW revision */
      { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC28_MDMNET) },
+    { USB_DEVICE_INTERFACE_CLASS(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EXS82, 0xff),
+      .driver_info = RSVD(1) | RSVD(2) | RSVD(3) },
      { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100),
        .driver_info = RSVD(4) },
      { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD120),


There is only one interface in this device that should be driven by optiom, the first interface which likely is a diag interface. All other interfaces are driven by CDC drivers and they will not be taken by option so no need for the blacklisting of them.
Remove the .driver_info line from the patch.

thanks
Lars




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux