Hi Heikki, Thanks for developing these patches :) On Wed, Nov 18, 2020 at 06:00:56PM +0300, Heikki Krogerus wrote: > Hi Prashant, > > The original discussion [1]. > > This proposal is in practice a compromise. I came to the conclusion > that we probable should expose the product type separately after all. > The reason for that is because we may in some cases actually know the > product type even when we don't have access to the Discover Identity > response. UCSI for example in practice gives us at least the cable > product type even though it does not let us know the response to the > Discover Identity command. > > So my proposal here is that we add an attribute for the product type > itself, showing the product type as a string. Then we also add the > attribute for the product type specific VDOs which we place under the > identity directory more or less the way you originally proposed. Sounds good to me. Best regards, -Prashant
