On Wed, Jul 22, 2009 at 02:39:20PM -0400, Alan Stern wrote: > This patch (as1266) changes the way usb-serial manages its minor > numbers. There's no need to retain a minor number after the device > has been disconnected, since the only thing the minor gets used for is > to determine which port corresponds to a device file during open(). > (It also gets used in serial_proc_show, but we don't have to worry > about that.) > > Returning minor numbers during serial_disconnect rather than > destroy_serial allows the numbers (and hence device node names) to be > reused even when a process is holding an unplugged device's file open. > This is what users expect to happen, and there's no reason not to do > it. To change this would be changing the way the code has worked for forever. Why would you want to change the userspace api this way? Userspace needs to drop the last reference of the device when it is finished with it. The code has always worked this way. Userspace gets notified of the device being removed with a hangup signal. If that notification somehow broke, then that should be fixed instead. So I'm not going to take this patch, sorry. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
