On Fri, Jul 24, 2009 at 06:53:17PM +0200, Oliver Neukum wrote: > Am Freitag, 24. Juli 2009 17:48:03 schrieb Trevor Pace: > > Removed useless return value variables. > > > > Signed-off By: Trevor Pace <trevor.pace@xxxxxx> > > These changes are a bad idea. They'll bite us in the ass as soon as we > change locking or need to do more cleanups. The preferred form of > error handling is > > r = op() > if (r < 0) > goto error_exit; > > I suggest that you don't apply them. I agree with you, and will not be applying them. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html