On Fri, Nov 13, 2020 at 12:24:57PM -0800, Utkarsh Patel wrote: > Thunderbolt rounded/non-rounded cable support is two bits value. Correcting > it as per the Thunderbolt 3 cable discover mode VDO changes done in the > Thunderbolt 3 alternate mode header. > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > -- > Changes in v2: > - Removed the fixes tag as there is no functional implication. > -- > --- > drivers/platform/chrome/cros_ec_typec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 31be31161350..8111ed1fc574 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -438,8 +438,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec, > if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) > data.cable_mode |= TBT_CABLE_LINK_TRAINING; > > - if (pd_ctrl->cable_gen) > - data.cable_mode |= TBT_CABLE_ROUNDED; > + data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); > > /* Enter Mode VDO */ > data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed); > -- > 2.17.1 thanks, -- heikki
