Re: [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

On 14/11/2020 20:13, Martin Blumenstingl wrote:

Hi Amjad,

On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur
<aouledameur@xxxxxxxxxxxx> wrote:
[...]
@@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy)
  {
         struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy);

+       reset_control_rearm(priv->reset);
please move reset_control_rearm after clk_disable_unprepare as
mentioned on the other patch to clean things up in reverse order of
initialization

Agreed, will fix it in next change !


         clk_disable_unprepare(priv->clk);

Thank you
Martin

Thank you for the feedback !

Best,

Amjad




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux