Hi,
On 10/11/20 11:50, Heikki Krogerus wrote:
> On Mon, Nov 09, 2020 at 10:15:36PM -0800, Prashant Malani wrote:
>> Set the number of altmodes available for a registered partner using the
>> Type C connector class framework routine.
>>
>> Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>
Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
Heikki, would you like to take these two through your tree? It'd help if you can
create an inmutable branch so I can pick other cros_ec_typec patches on top of it.
Thanks,
Enric
>> ---
>>
>> Changes in v2:
>> - Patch introduced for the first time in v2.
>>
>> drivers/platform/chrome/cros_ec_typec.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
>> index ce031a10eb1b..743a28426f98 100644
>> --- a/drivers/platform/chrome/cros_ec_typec.c
>> +++ b/drivers/platform/chrome/cros_ec_typec.c
>> @@ -621,6 +621,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>> struct cros_typec_altmode_node *node;
>> struct typec_altmode_desc desc;
>> struct typec_altmode *amode;
>> + int num_altmodes = 0;
>> int ret = 0;
>> int i, j;
>>
>> @@ -647,9 +648,16 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>>
>> node->amode = amode;
>> list_add_tail(&node->list, &port->partner_mode_list);
>> + num_altmodes++;
>> }
>> }
>>
>> + ret = typec_partner_set_num_altmodes(port->partner, num_altmodes);
>> + if (ret < 0) {
>> + dev_err(typec->dev, "Unable to set partner num_altmodes for port: %d\n", port_num);
>> + goto err_cleanup;
>> + }
>> +
>> return 0;
>>
>> err_cleanup:
>> --
>> 2.29.2.222.g5d2a92d10f8-goog
>
> thanks,
>
