On Wed, Nov 04, 2020 at 03:20:38PM +0100, Greg KH wrote: > > +/** > > + * tb_service_debugfs_remove() - Remove service debugfs directory > > + * @svc: Thunderbolt service pointer > > + * > > + * Removes the previously created debugfs directory for @svc. > > + */ > > +void tb_service_debugfs_remove(struct tb_service *svc) > > +{ > > + debugfs_remove(svc->debugfs_dir); > > debugfs_remove_recursive() just to be safe that you really did clean > everything up? As you aren't "owning" this directory here, you don't > know what will get added by some other patch :) Good point. I'll change it to debugfs_remove_recursive(). > Other than that tiny nit, this series looks good to me, nice work. Thanks!