On Tue, Nov 03, 2020 at 12:40:14PM -0800, Davidlohr Bueso wrote: > On Mon, 02 Nov 2020, Bueso wrote: > > >There is > >also no need anymore for atomic allocations. > > Bleh this is a brain fart - obviously not true as usb_submit_urb() is > called under mos_parport->listlock. I'll send a v2 unless you have > any objections. The conversion looks good to me otherwise; it's not making this parport mess any worse than it already is... But please try to be a bit more stringent when updating the comments and printk messages, for example, "runs *from* a workqueue", "schedule a *worker*" or "queue a work item", etc. Johan
