On Fri, Oct 30, 2020 at 06:22:20PM +0100, Yann Garras wrote: > Hi, > Thank you for your response. > > Personally, I find more valuable to read : > { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, TELIT_PRODUCT_LE910C1_EUX, > 0xff), > .driver_info = NCTRL(0) | RSVD(3) }, > > Rather than > { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1031, 0xff), > .driver_info = NCTRL(0) | RSVD(3) }, Sure, but we try to keep the model name in a comment after the entry. That way you get a more compact notation (one line less) and you can still find the model name easily. > But where I agree with you, is to make a choice and apply it. Yeah, the current half-measure isn't optimal. Johan