Hi, these are some changes for r8152. At first I just wanted to add support for rtl8156 (which supports 2500baseT), by porting from Realtek's out-of-tree driver. It instead turned out into cosmetic changes first, though. Please review this. I would much like to try to port rtl8156 after these patches are merged, so that _modify functions can be used. Thanks. Marek Marek Behún (5): r8152: use generic USB macros to define product table r8152: cosmetic improvement of product table macro r8152: add MCU typed read/write functions r8152: rename r8153_phy_status to r8153_phy_status_wait r8152: use *_modify helpers instead of read/write combos drivers/net/usb/r8152.c | 1156 +++++++++++++-------------------------- 1 file changed, 387 insertions(+), 769 deletions(-) base-commit: 6d89076e6ef09337a29a7b1ea4fdf2d892be9650 -- 2.26.2