On Tue, Nov 03, 2020 at 05:46:37PM +0800, Hayes Wang wrote: > diff --git a/include/linux/usb/usb_vendor_id.h b/include/linux/usb/usb_vendor_id.h > new file mode 100644 > index 000000000000..23b6e6849515 > --- /dev/null > +++ b/include/linux/usb/usb_vendor_id.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > + <snip> No, this is not ok, sorry. Please see the top of the pci_ids.h file why we do not do this. There is nothing wrong with putting the individual ids in the different drivers, we don't want one single huge file that is a pain for merges and builds. We learn from our past mistakes, please do not fail to learn from history :) thanks, greg k-h
