Re: [PATCH v2] USB: apple-mfi-fastcharge: fix reference leak in apple_mfi_fc_set_property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 31, 2020 at 06:11:44PM +0800, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage at first and it
> will resume the device later. If runtime of the device is
> active or has error(else....), resume operation will fail. If
> we do not call put operation to decrease the reference, the
> result is that this device cannot enter the idle state and
> always stay busy or other non-idle state.
> 
> Fixes: 249fa8217b846 ("USB: Add driver to control USB fast charge for iOS devices")
> Signed-off-by: Zhang Qilong <zhangqilong3@xxxxxxxxxx>
> ---
>  drivers/usb/misc/apple-mfi-fastcharge.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

What changed from v1?  Always put that below the --- line.

Can you fix that up and send a v3?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux