On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@xxxxxxxxxx> wrote: The title can be more precise. > Fix the following sparse warning: > > drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static? Do we really need to know the path? > The sync_all_pins has only call site within brcmstb-usb-pinmap.c sync_all_pins() > It should be static Missed period. -- With Best Regards, Andy Shevchenko