在 2020/10/26 23:05, Alan Stern 写道:
On Mon, Oct 26, 2020 at 05:06:57PM +0800, Tang Bin wrote:
If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
tegra_ehci_probe().
Fixes: 79ad3b5add4a ("usb: host: Add EHCI driver for NVIDIA Tegra SoCs")
Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/host/ehci-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 75a075daf..7b0efaf15 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -479,9 +479,9 @@ static int tegra_ehci_probe(struct platform_device *pdev)
u_phy->otg->host = hcd_to_bus(hcd);
irq = platform_get_irq(pdev, 0);
- if (!irq) {
- err = -ENODEV;
- goto cleanup_phy;
+ if (irq < 0) {
+ err = irq;
+ goto cleanup_phy;
}
otg_set_host(u_phy->otg, &hcd->self);
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
The "if (!irq)" statement occurs at least one other driver in this
directory. Would you like to submit a patch for ehci-xilinx-of.c as
well?
OK, I will check this file out. Thanks!
Tang Bin
