On Thu, Oct 22, 2020 at 12:13 AM Prashant Malani <pmalani@xxxxxxxxxxxx> wrote: > > Thanks for reviewing the patch, Greg. > > On Wed, Oct 21, 2020 at 11:56 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > +What: /sys/class/typec/<port>-cable/identity/product_type_vdo > > > +Date: October 2020 > > > +Contact: Prashant Malani <pmalani@xxxxxxxxxxxx> > > > +Description: > > > + Product Type VDOs part of Discover Identity command result. 3 values > > > + are displayed (for the 3 possible Product Type VDOs), one per line. > > > + The values will show 0s until Discover Identity command result becomes > > > + available. The values can be polled. > > > > Why are you describing the same value in two different locations? > > Both cable and partner can have Discover Identity VDOs and they are > listed separately in sysfs. > The other VDOs (id_header, cert_stat and product) have separate > descriptions for cable and partner too. > Perhaps there is a case for consolidating the listings here (factor > out the ones which are common to cable and partner). > Just an update: I added a patch to the series which consolidates these repeat identity entries into 1 location: https://lore.kernel.org/linux-usb/20201023214328.1262883-1-pmalani@xxxxxxxxxxxx/ Thanks and best regards,
