Hi Greg, On Thu, Oct 22, 2020 at 12:17 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > +What: /sys/class/typec/<port>-partner/identity/product_type_vdo > > > > +Date: October 2020 > > > > +Contact: Prashant Malani <pmalani@xxxxxxxxxxxx> > > > > +Description: > > > > + Product Type VDOs part of Discover Identity command result. 3 values > > > > + are displayed (for the 3 possible Product Type VDOs), one per line. > > > > > > sysfs is "one value per file", not "one value per line". This is not > > > ok. > > > > I see. Would listing these out as three separate vdos (i.e vdo0, vdo1, > > vdo2) be better? > > Given that your current implementation is not acceptable, something has > to change :) Got it. I'd like to see if Heikki has any suggestions on naming these entries better. Thanks again and best regards, -Prashant > > thanks, > > greg k-h