Re: Bug caused by 53965c79c2db (USB: Fix device driver race)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/10/2020 09.18, Bastien Nocera wrote:
On Wed, 2020-10-21 at 09:08 -0400, M. Vefa Bicakci wrote:
On 21/10/2020 07.53, Bastien Nocera wrote:
[Snipped by Vefa]

I have no idea why there isn't a match function. Patch v1 had a
huge
table:
https://marc.info/?l=linux-usb&m=157062863431186&w=2
and v2 already didn't had that comment, but no .match function:
https://marc.info/?l=linux-usb&m=157114990905421&w=2

I'll prepare a patch that adds a match function. I'll let you
(Vefa)
look at which of your patches need backporting though, as I'm
really
quite a bit lost in the different patch sets and branches :/

Hello Bastien,

Having found the root cause of the issue by going through Pany's
logs and having proposed a solution, I was hoping to get credit
for the resolution of the issue by authoring the patch.

I don't care either way. Attached are the 2 patches I had made and was
in the process of compiling and testing, feel free to adapt them,
change the authorship, etc.

Note that you mentioned you'd need to "replace the ID table with
a match function", which will mean that the driver isn't automatically
loaded when a device gets plugged in. So that wouldn't have worked.

Let me know when you've made your patch, as I'll need to update this
bug when there's something to test:
https://bugzilla.redhat.com/show_bug.cgi?id=1878347

Cheers

Hello Bastien,

Sorry about my delayed reply. Thank you, and I appreciate your understanding.
I intend to continue the work starting later today, and I will make
sure that you are credited by using the co-developed-by tag in the
patches, as you have mentioned in your more recent e-mail in this thread.

I will investigate/verify the ID table vs. match function aspect
as well; I understand that my suggestion could be incorrect.

Thanks again,

Vefa



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux