Hi Jens, On Sat, Oct 17, 2020 at 4:57 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > > Hi, > > There's a new warning in -git if: > > CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE > > isn't set in the .config: > > drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’: > drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label] > 611 | error_debugfs: > | ^~~~~~~~~~~~~ > > which was caused by this commit: > > commit e1c08cf23172ed6fb228d75efc9f4c80a6812116 > Author: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Date: Sat Jul 4 00:50:43 2020 +0200 > > usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails thanks for pointing this out! It seems like v2 of my patch was picked. v3 [0] had this exact issue fixed which has been found by the kbuild test robot I can send a patch adding the #ifdefs so it can go into a for-linus tree with a Fixes tag for the above commit is there anything apart from that which needs to be done? Best regards, Martin [0] https://lkml.org/lkml/2020/7/27/1429