On 14.10.2020 09:53, Leon Romanovsky wrote: > On Wed, Oct 14, 2020 at 08:13:47AM +0200, Heiner Kallweit wrote: >> On 14.10.2020 07:42, Leon Romanovsky wrote: >>> On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote: >>>> On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: >>>>> In several places the same code is used to populate rtnl_link_stats64 >>>>> fields with data from pcpu_sw_netstats. Therefore factor out this code >>>>> to a new function dev_fetch_sw_netstats(). >>>>> >>>>> v2: >>>>> - constify argument netstats >>>>> - don't ignore netstats being NULL or an ERRPTR >>>>> - switch to EXPORT_SYMBOL_GPL >>>> >>>> Applied, thank you! >>> >>> Jakub, >>> >>> Is it possible to make sure that changelogs are not part of the commit >>> messages? We don't store previous revisions in the git repo, so it doesn't >>> give too much to anyone who is looking on git log later. The lore link >>> to the patch is more than enough. >>> >> I remember that once I did it the usual way (changelog below the ---) David >> requested the changelog to be part of the commit message. So obviously he >> sees some benefit in doing so. > > Do you have a link? What is the benefit and how can we use it? > https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1873080.html > Usually such request comes to ensure that commit message is updated with > extra information (explanation) existed in changelog which is missing in > the patch. > > Thanks > >> >>> 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats") >>> >>> Thanks >>> >>
