Hi Thomas, Thank you for the patch. On Tue, Oct 13, 2020 at 04:26:18PM +0200, Thomas Gleixner wrote: > in_interrupt() covers hard and soft interrupt servicing and bottom half > disabled contexts, which is semantically ill defined. > > The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is > therefore as useful as "Context: unknown'. Remove it. > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/omap3isp/ispccdc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > --- a/drivers/media/platform/omap3isp/ispccdc.c > +++ b/drivers/media/platform/omap3isp/ispccdc.c > @@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc > ISPCCDC_LSC_BUSY; > } > > -/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine > +/* > + * __ccdc_lsc_configure - Apply a new configuration to the LSC engine > * @ccdc: Pointer to ISP CCDC device > * @req: New configuration request > - * > - * context: in_interrupt() > */ > static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc, > struct ispccdc_lsc_config_req *req) > -- Regards, Laurent Pinchart
