On 11.10.2020 21:54, Stephen Hemminger wrote:
> On Sun, 11 Oct 2020 21:36:43 +0200
> Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
>
>> +void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
>> + struct pcpu_sw_netstats __percpu *netstats)
>
> netstats is unmodified, should it be const?
>
>> +{
>> + int cpu;
>> +
>> + if (IS_ERR_OR_NULL(netstats))
>> + return;
>
> Any code calling this with a null pointer is broken/buggy, please don't
> ignore that.
>
Thanks, I'll consider both points in a v2.
