Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 08.10.2020 6:57, Pawel Laszczak wrote:

Siergei,

   Sergei, or, more correctly, Sergey. :-)



On 10/7/20 11:15 AM, Roger Quadros wrote:

[...]
Patch removes not used variable 'length' from
cdns3_wa2_descmiss_copy_data function.

Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>

Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

   No "commit" is needed here.

Can you explain why?

I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
or because it's only warning - not error.

Am I right ?

   No, it's because the format is:

Fixes: <SHA1> ("<summary>")

no word "commit" is needed. :-)

Acked-by: Roger Quadros <rogerq@xxxxxx>
[...]

Regards,
Pawel

MBR, Sergei



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux