On 10/5/20 4:08 AM, Greg KH wrote: [ ... ] >>> What ever happened with this patch, is there still disagreement? >>> >> >> Yes, there is. I wouldn't have added the conditional without reason, >> and I am concerned that removing it entirely will open another problem. >> Feel free to apply, though - I can't prove that my concern is valid, >> and after all we'll get reports from the field later if it is. > > Ok, can I get an ack so I know who to come back to in the future if > there are issues? :) > Not from me, for the reasons I stated. I would be ok with something like: - if (tcpm_port_is_disconnected(port)) + if (tcpm_port_is_disconnected(port) || + (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2))) to narrow down the condition. Guenter
