RE: [PATCH v3 1/6] dt-bindings: usb: xhci: add property to disable xhci 64bit support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,
> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Wednesday, September 30, 2020 2:11 AM
> To: Jun Li <jun.li@xxxxxxx>
> Cc: shawnguo@xxxxxxxxxx; balbi@xxxxxxxxxx; mathias.nyman@xxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; Anson Huang <anson.huang@xxxxxxx>; Aisheng Dong
> <aisheng.dong@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Andy Duan
> <fugang.duan@xxxxxxx>; Joakim Zhang <qiangqing.zhang@xxxxxxx>; Horia
> Geanta <horia.geanta@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 1/6] dt-bindings: usb: xhci: add property to disable
> xhci 64bit support
> 
> On Tue, Sep 22, 2020 at 06:46:47PM +0800, Li Jun wrote:
> > Add a property "xhci-64bit-support-disable" to disable xhci 64bit
> > address dma, some SoC integration may not support 64bit DMA but the
> > AC64 bit (bit 0) of HCCPARAMS1 is kept to be 1.
> 
> Use 'dma-ranges' for this.

Thanks, sent out v4 with dma-ranges property approach.

Li Jun
> 
> > Signed-off-by: Li Jun <jun.li@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > index 0c5cff8..26446fb 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -28,6 +28,9 @@ Optional properties:
> >    - quirk-broken-port-ped: set if the controller has broken port disable
> mechanism
> >    - imod-interval-ns: default interrupt moderation interval is 5000ns
> >    - phys : see usb-hcd.yaml in the current directory
> > +  - xhci-64bit-support-disable: set if the AC64 bit (bit 0) of HCCPARAMS1
> is
> > +    set to be 1, but the controller actually can't handle 64-bit address
> > +    due to SoC integration.
> >
> >  additionally the properties from usb-hcd.yaml (in the current
> > directory) are  supported.
> > --
> > 2.7.4
> >




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux